silverstripe/silverstripe-blog

Plz add $request param to BlogController::index() at the version 3.2.4

Closed this issue · 3 comments

a2nt commented

The other modules require stable version of silverstipe/blog module for example blocks extension and I'm tired to change manually
BlogController::index() to BlogController::index(SilverStripe\Control\HTTPRequest $request)

NightJar commented

Hi @a2nt - can you please describe the issue you're seeing with more detail?
Are you also saying that you've tested a fix, and it works? If so, how would you feel about creating a pull request against the 3.2 branch to patch this in the next release?

a2nt commented

Well that's easy

PageController::index(SilverStripe\Control\HTTPRequest $request)
And BlogController extends PageContoller and it makes a notice

Yes I have tested it among different websites and it works ok. You have fixed this issue at the master branch already and actually most of SilverStripe controllers has $request param at the index() method:
ControllerClass::index($request)

  • 👍1
ScopeyNZ commented

I agree that not having it was an oversight. Unfortunately as updating it is a breaking API change it has to go in the next major - hence it only exists in master (and the invalid 3.2.2 tag).

There's not really anything we can do here without backporting a breaking change into a minor release.

I think 4.x-dev is pretty stable right now - not sure when we're likely to tag it though.

FYI here's the context on the change made to master: #550

  • 👍1