silverstripe/silverstripe-elemental

HTMLEditorField::setRows method doesn't work in Elemental

Closed this issue · 1 comments

Description

HTMLEditorField::setRows method doesn't work in Elemental since height attribute is not passed.

Related issue

Replication steps

Add the following to your content block and then try to inline edit it

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('Content');
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent1')->setRows(2));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent2')->setRows(4));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent3')->setRows(5));
        $fields->addFieldToTab('Root.Main', HTMLEditorField::create('OtherContent4')->setRows(10));
  
        return $fields;
    }

PRs

PRs merged