FormBuilder validation message does not show for TextCheckboxGroupField

Question

FormBuilder validation message does not show for TextCheckboxGroupField

Closed this issue 7 months ago · 6 comments

emteknetnz commented 7 months ago

TextCheckboxGroupField is a CompositeField used by elemental

FormSchema validation messages from inline submit do not show the red message

Answer 1 · 2024-02-28T22:15:00.000Z

Is this a problem for just the specific field you've mentioned, or does this affect all composite fields?

Answer 2 · 2024-02-29T02:11:52.000Z

Haven't tested, will need be checked as part of fixing this issue

Answer 3 · 2024-02-29T02:13:18.000Z

It affects the priority imo. I probably wouldn't bother with this if it's just that field, but if it's all composite fields then it's worth looking at.

Answer 4 · 2024-02-29T04:05:35.000Z

I'd expect it to only be the TextCheckboxGroupField which lives in elemental rather than admin, because I can get a message to show if I stop passing the noHolder: true prop in TextCheckboxGroupField.js, though it messes up styling for the form field

Answer 5 · 2024-02-29T06:04:29.000Z

IMHO impact is more than low. Finding elements to associate or link is not feasible without title/name.

Answer 6 · 2024-02-29T20:51:33.000Z

I've done a little more investigation, the issue here is really whether the noHolder props is passed the field rendered by formbuilder which causes the message (validation message) to not be rendered - https://github.com/silverstripe/silverstripe-admin/blob/2/client/src/components/FieldHolder/FieldHolder.js#L183.

So this isn't a bug, it's a feature.

I've resolved this for TextCheckboxGroupField in elemental in this PR by removing the noHolder prop for the Title field and updating CSS so it still looks as it did before

I've close this issue