[feature] type support

Question

[feature] type support

ghostdevv opened this issue 3 years ago · 5 comments

Currently there are no types shipped with the package, would be nice to do this

Answer 1 · 2022-03-12T00:08:26.000Z

In terms of options to auto generate types, you can either stick with the current rollup build system and use sveld to generate types. Or you can switch to sveltekit package and use that to build the package

Answer 2 · 2022-11-04T15:44:42.000Z

I've created a type definition. You can add it as dev dep.
https://www.npmjs.com/package/@types/svelte-range-slider-pips

Answer 3 · 2022-11-04T18:53:49.000Z

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

Answer 4 · 2022-11-05T10:23:51.000Z

I've created a type definition. You can add it as dev dep. https://www.npmjs.com/package/@types/svelte-range-slider-pips

Thanks @i7N3 ... is this a normal/accepted way to handle the issue? And if so is the issue closable? Or should the types be defined inside the repo?

Yes, if a package does not bundle its own types.
Yes.
When a package bundles its own types, types should be removed from Definitely Typed to avoid confusion.

As someone mentioned here, there is a better way to rewrite svelte-range-slider-pips to typescript.