simile-widgets/exhibit

Custom Tabular view content not possible any more (since #169?)

Closed this issue · 1 comments

camilstaps commented

As I understand, it is possible to do something like the following:

<div data-ex-role="view"
    data-ex-view-class="Tabular"
    data-ex-label="Compare Their Wealth"
    data-ex-columns=".number, .ageAtPeak, .wealth, .origin, .origin-country, .company"
    data-ex-column-labels="rank &amp; name, age at peak, wealth in billion USD, origin, country of origin, company"
    data-ex-sort-column="0"
    data-ex-sort-ascending="true"
    >
    <table style="display:none;">
      <tr>
        <td>
          <span data-ex-content=".number"></span>:
          <span data-ex-content=".label"></span>
        </td>
        <td><div data-ex-content=".ageAtPeak"></div></td>
        <td><div data-ex-content=".wealth"></div></td>
        <td><div data-ex-content=".origin"></div></td>
        <td><div data-ex-content=".origin-country"></div></td>
        <td><div data-ex-content=".company"></div></td>
      </tr>
    </table>
</div>

This would make it possible to sort on the .number, while displaying both .number and .label in one column. (This isn't useful in this example, but is in other cases).

This was possible on 3.1.2-rc1 (it showed e.g. "1: John Davison Rockefeller"), but isn't possible any longer on the current master (it now shows e.g. "1"). I created a sample at http://conversationaltorah.camilstaps.nl/billionaires.html, which is a copy of the billionaires demo adapted to show the problem. The code it uses is 138dd86, with #173 and #174 merged in (these PRs don't affect this, and I need them on another page).

I did some testing:

My (possibly premature) conclusion is that something went wrong in #169.

camilstaps commented

Sorry, I didn't get a notification of this. This fixes it, thanks @cdenise.