simon-weber/Autoplaylists-for-Google-Music

Numbers don't match

brianzam opened this issue · 25 comments

brianzam commented

Hi Simon,

Odd thing happenng. I have a playlist 'Thumbs Up Plus' as follows:

Synced 22/06/2018, 22:46:16 by Autoplaylists for Google Music™ to contain: (rating thumb equals "up" and play count less than 10 and (last played earlier than "10 days ago" or last played between now and "20 minutes ago")) sorted by: lastPlayed ascending.

When I run it in test, I get the numbers I'd expect (705). Whenever I sync, only 332 songs appear in the Google Playlist.

Thanks in advance,

Brian

simon-weber commented

This sounds like the same thing as #185. I don't yet see anything in my reporting to indicate a widespread issue, thankfully. Can you give the recommendation at #185 (comment) a try?

brianzam commented

HI Simon. tried it, no difference, sorry.

simon-weber commented

Gotcha. Can you try sending over some logs so I can take a look? Specifically I'm interested in the contents of lines that start with finished sync. I think you'll need to click on the responses section to expand the details (if there's a way to expand or print it all, that'd be ideal).

brianzam commented
simon-weber commented

Is there anything interesting if you click further into the responses section? It's the contents of the mutate_response array that will have data like "too many tracks", etc.

brianzam commented
simon-weber commented

Sorry to hear it's gotten worse! I'll make some time this evening to dig into it a bit more.

Those most recent errors look related to not being able to pull in your library from Google, which is hopefully unrelated (unless something has degraded further on Google's end).

simon-weber commented

Also, a quick question: do you have multiple Google accounts signed in at once? If so, does it help if you sign out of all but the one used for Music and then reload the extension? There's some auth errors in the earlier logs which suggest that might be related.

Also, do you have a subscription Music account, or a free one?

simon-weber commented

I had an idea in the other thread that's worth trying for you as well: #188 (comment). This seems to have solved the problem for them.

simon-weber commented

@brianzam any luck with the auth token refresh? If it works for you I'll probably send it out to the mailing list in case anyone else is seeing it.

brianzam commented
simon-weber commented

Having no token is pretty bizarre. Glad that part is worked out, though.

I think what I'll do is push changes to automatically report the parts of #185 (comment) that I'm interested in.

Overloading still seems like the most likely cause, though if you were without an auth token for a while it'd expect things to have gotten better. Is it possible there's another computer that's also running the extension? Disabling the extension for a day or two might be worth a shot if that's the case; I think that state would eventually propagate to all devices.

brianzam commented
simon-weber commented

I just pushed a few changes in 5.10.0 that should help:

  • Google's response codes are now logged and reported
  • the backoff status - when the extension disables itself to avoid overloading Google - now shows up on the syncing page
  • the syncing page will now properly stop the blinker (rather than just logging that timeout you posted above)

The first one is most important. There should now be a line in the background script logs that starts with "codeCounts" for each sync. My guess is yours will show a mix of "OK" and something else, since your syncs are only partially applying. I've also started sending these to GA, which might help in figuring out why some users get particular codes more often.

brianzam commented
simon-weber commented

Got it. This at least looks more normal, and seems to suggest things are just overloaded on Google's end. The TOO_MANY_ITEMS bit is especially indicative of this: it seems to mean that Google has gotten behind on the state of your playlists, and isn't processing entry deletes fast enough to keep up with additions.

This might sound ridiculous, but I'm pretty sure this will fix itself if you disable the extension and wait a few days before re-enabling (as solution that, as Slack puts it I "suggest to you now only with great regret and self-loathing"). It's also a good bet to turn your sync period way up to reduce syncs once you re-enable and enable mutation batching in the settings menu.

brianzam commented
simon-weber commented

Sounds good. Keep me posted.

Good catch with the empty playlists: I'll look into that and see if there's a bug on my end.

brianzam commented
simon-weber commented

Sounds good.

"Conflict" is a new code to me. According to my metrics there's only a handful of users who have ever seen it before.

simon-weber commented

Whoops, did not mean to close this.

brianzam commented
brianzam commented
simon-weber commented

The TOO_MANY_ITEMS code is really interesting, especially since I've got someone else with the same symptoms.

Can you try a few tests for me?

  • what happens if you limit the playlist to a few more than the current size, to force fewer songs to be added at once?
  • if you can figure out a few songs that are missing, what happens if you add them manually through the web interface? I'm especially curious to see if there's a difference when doing it from a mobile app instead (since that's the interface the extension uses)
  • are you able to add any songs to the playlist manually?
  • what about if you delete everything from the playlist and let the extension try to refill it?
  • what happens if you duplicate the autoplaylist (so that it creates a new playlist on Google's end)?
simon-weber commented

Heads up that I'm moving this into a new issue so I can combine multiple threads: #193. If you get a chance, please put your responses over there.