simonh1000/angular-http-server

Enable compression

oderayi opened this issue · 12 comments

oderayi commented

Would be nice to have a switch to enable compression.

I'm using this to test my Angular production build and auditing via Lighthouse. Compression seems to be the major bottleneck for performance rating.

simonh1000 commented

A PR for this would be welcome

oderayi commented

Hi @simonh1000 , please expect my PR soon.

  • 👍3
joaosousafranco commented

@oderayi are you still working on this? The goal is to support gzip right?

oderayi commented

@joaosousafranco face palm moment. My apologies guys - I have the update on a local fork but I haven't got the time to refactor it into a "PR-ready" state yet. Yes the goal is to support gzip.

oderayi commented

@simonh1000 @joaosousafranco So I just filed my PR for the update. Hope it gets merged soon.

simonh1000 commented

@joaosousafranco can you try testing it as well

  • 👍1
joaosousafranco commented

looks ok

  • 👍2
joboyx commented

any update on this guys? would be very helpful if this gets pushed to next release. :)

simonh1000 commented

Just a couple of questions for the author and we'll be good to go.
Interested in what the use cases were though for this - just to repeat this is NOT a production server

haskelcurry commented

Any updates? 🙂

simonh1000 commented

the pr is in review

AhmedBenyahia commented

This PR is taking 3 years to be reviewed/merged ??