simonw/datasette-app

Confirm that Electron auto-updates actually work

simonw opened this issue · 6 comments

simonw commented

Opening a separate issue for confirming that it actually works (and so I can close this one).

Originally posted by @simonw in #58 (comment)

simonw commented

I'm going to ship it in 0.2 (see a02e63e) and then figure out an excuse to ship a 0.2.1 release afterwards to confirm if the auto update works as advertised.

simonw commented

0.2.0 is out with this feature now, so next time I ship a release I should be able to tell if auto-updating works or not!

simonw commented

I'm not sure this is working. My install of 0.2.0 has not yet prompted me to install 0.2.1.

https://github.com/electron/update.electronjs.org#manual-setup mentions this:

const server = 'https://update.electronjs.org'
const feed = `${server}/OWNER/REPO/${process.platform}-${process.arch}/${app.getVersion()}`

I ran that in the Electron debugger:

DevTools

And got back https://update.electronjs.org/simonw/datasette-app/darwin-x64/0.2.1 which says this:

No updates found (needs asset matching *{mac,darwin,osx}*.zip in public repository)

So I think I'm using the wrong filename.

simonw commented

I renamed the asset file on the https://github.com/simonw/datasette-app/releases/tag/0.2.1 page to Datasette-mac.app.zip and relaunched the app and got this:

Datasette__temporary__plugin_directory_and_Confirm_that_Electron_auto-updates_actually_work_·_Issue__106_·_simonw_datasette-app

I confirmed that this was 0.2.1 (since I haven't yet shipped #116) by enabling the debug menu and closing all windows to check that the Chrome DevTools menu item became grayed out - which it did.

simonw commented

This works now!