simonw/datasette-auth-passwords

Correctly bundle the templates in the installable package

Closed this issue · 2 comments

The plugin is broken if you use pip install datasette-auth-passwords to install it. You get none of the templates given were found: password_login.html on the /-/login page.

Weird, it's there in the .whl I got by running python setup.py bdist_wheel:

simon@Simons-MacBook-Pro f % cp ~/Dropbox/Development/datasette-auth-passwords/dist/datasette_auth_passwords-0.2a0-py3-none-any.whl .
simon@Simons-MacBook-Pro f % unzip datasette_auth_passwords-0.2a0-py3-none-any.whl
Archive:  datasette_auth_passwords-0.2a0-py3-none-any.whl
  inflating: datasette_auth_passwords/__init__.py  
  inflating: datasette_auth_passwords/utils.py  
  inflating: datasette_auth_passwords/templates/password_tool.html  
  inflating: datasette_auth_passwords-0.2a0.dist-info/METADATA  
  inflating: datasette_auth_passwords-0.2a0.dist-info/WHEEL  
  inflating: datasette_auth_passwords-0.2a0.dist-info/entry_points.txt  
  inflating: datasette_auth_passwords-0.2a0.dist-info/top_level.txt  
  inflating: datasette_auth_passwords-0.2a0.dist-info/RECORD  

Oh no it's not! https://datasette-auth-password-demo-j7hipcg4aq-uw.a.run.app/-/password-tool works because I included password_tool.html but the /-/login page doesnt work because I forgot to add that to setup.py`:

package_data={"datasette_auth_passwords": ["templates/password_tool.html",]},