"WARNING, may skip scrobbles" text for Active App Notification option is unclear
tobek opened this issue · 1 comments
It's not clear if enabling or disabling the option is what might cause scrobble skips. It wasn't until I saw this comment #536 (comment) that I understood what it meant.
I'd replace with something like "WARNING: Disabling this may skip scrobbles, unless you ensure that this app is not battery optimized (Android Settings > Apps)."
I'm happy to go ahead and make a PR for this change if the maintainer(s) agree with the copy update.
Update: just saw there's actually a PR for this already #563 though I disagree with the copy there - I think it should still say "or else scrobbles may be skipped" or something. There isn't an open issue I could see for this though so leaving the issue here.
I found my way here via Google, just started using the app recently. Since the Battery Optimization is part of the permissions setup flow, the persistent notification should probably default to 'Off' in my opinion.
I'm on the Android 11 Beta, and the notification is a bit annoying--even set to silent priority it was displaying on my lock screen until a reboot. It also has the side effect of displaying explicit language in track titles (if one listens to that type of thing) prominently even on a locked phone.
The linked PR clears it up, though it uses the spelling "optimisations" vs "optimizations", and the spelling with a 'z' is used elsewhere in the app. That's just a nitpick though