simsong/dfxml

dfxml_configure.m4 should set AC_LANG to C++ before checking for exiv2 headers

Closed this issue · 4 comments

ant1 commented

I'm compiling bulk_extractor 1.4.0 beta 2
During configure:
...
configure: Including dfxml_configure.m4 from dfxml
checking afflib/afflib.h usability... yes
checking afflib/afflib.h presence... yes
checking for afflib/afflib.h... yes
checking err.h usability... yes
checking err.h presence... yes
checking for err.h... yes
checking expat.h usability... yes
checking expat.h presence... yes
checking for expat.h... yes
checking exiv2/image.hpp usability... no
checking exiv2/image.hpp presence... no
checking for exiv2/image.hpp... no
checking libewf.h usability... yes
checking libewf.h presence... yes
checking for libewf.h... yes
...
But exiv2 is installed and exiv2/image.hpp is here.
Maybe there should be AC_LANG_PUSH(C++) / AC_LANG_POP() aroung the check for exiv2/image.hpp header.

Good idea. Although perhaps we should just take out exiv2, as we are abandoning it. What's your thought?

Fixed in 1858498..2e17afb.

ant1 commented

If exif works better than exiv2 I see not problem abandoning it.

where is no exif that we use. bulk_extractor has its own exif implementation, but it's not suitable for anything other than bulk_extractor. exiv2 does more, but it is buggier.