simsong/dfxml

Symlinks hardcode a specific version of automake

Closed this issue · 3 comments

Hi.

There are two build-related symlinks here:

src/INSTALL and src/depcomp

These both point to /usr/share/automake-1.13/.... This is clearly only meaningful if that is the version of automake that is being used. Is the intent to require automake 1.13? What if automake 1.14 is installed? Should we expect the build to work?

I'm building a package for tcpflow 1.4.4. I'm not having a build issue per se, but a packaging issue related to broken symlinks with automake 1.14. If you can resolve this on your end, that'll slightly simplify my life. If you want to keep it as is, please let me know and I'll work around it.

Thanks

Sorry about that. I didn’t put those symlinks there, they were put there by automake. Apparently if you do a ‘make dist’ on my system the .tar.gz file resolves the links, but if you are making it from the git repository it does not. See [1]. The .tar.gz shouldn’t have symlinks in it, though. From where are you getting them, directly from the git repo?

[1] https://lists.debian.org/debian-mentors/2000/09/msg00106.html
On Jan 5, 2014, at 5:17 AM, Dima Kogan notifications@github.com wrote:

Hi.

There are two build-related symlinks here:

src/INSTALL and src/depcomp

These both point to /usr/share/automake-1.13/.... This is clearly only meaningful if that is the version of automake that is being used. Is the intent to require automake 1.13? What if automake 1.14 is installed? Should we expect the build to work?

I'm building a package for tcpflow 1.4.4. I'm not having a build issue per se, but a packaging issue related to broken symlinks with automake 1.14. If you can resolve this on your end, that'll slightly simplify my life. If you want to keep it as is, please let me know and I'll work around it.

Thanks


Reply to this email directly or view it on GitHub.

Fixed in 4d54ca2.

Thanks for patching this. I am using the repo, so I was seeing the links. Thanks again.