sinatra/mustermann

Expand hash and array

tobidelius opened this issue · 4 comments

I don't know if this is a bug or just not supported but I tried this eariler:

pattern = Mustermann.new("/books/:id")
pattern.expand(:append, id: 5, include: ["foo"])
Expected: # => "/books/5?include[]=foo"
Actual: # => "/books/5?include=foo"

What do you guys say?

ping

@sandelius I'm sorry for the late reply. I've been so busy recently. However, this feature looks reasonable for me.
If you can dig up into this problem, please write a patch or expected spec.
I will seriously face this problem whenever I can spare time

zzak commented

To be honest, I'm not sure :( but at this point any behavior change we should treat with caution

@zzak That's why I proposed it before 1.0 ^^ :)