sindresorhus/atom-editorconfig

Add support for the new buffer API

samcv opened this issue · 4 comments

samcv commented

Issuehunt badges

The whitespace package added support here: atom/whitespace#157

The new API was added to Atom here: atom/atom#14435

This should greatly speed up removing trailing whitespace for files, especially for large files.

IssueHunt Summary

Sponsors (Total: $60.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

Hi @samcv - thank you very much for getting in touch and this delightful hint. I would like to add this enhancement to the next release.

I'd like to beg for patience until i'm back from vacation (next week). 😄 ☕️

samcv commented

@florianb no problem. Glad the information was apreciated and thank you for your work on the EditorConfig package. :-)

@IssueHunt has funded $60.00 to this issue.


Nothing to do here, really. We're already using the TextBuffer API's methods for efficient searching/replacing; the optimisations referred to in atom/whitespace#157 were addressing the use of String.prototype.search instead of the search logic provided natively TextBuffer.