sindresorhus/conf

TypeScript types should take into account defaults

sindresorhus opened this issue 4 years ago · 0 comments

sindresorhus commented 4 years ago

https://github.com/sindresorhus/electron-store/blob/966a9c736318c6c51083de08e5eb5d1276e00047/index.test-d.ts#L47 should not be number | undefined as it already has a default value defined in the constructor: https://github.com/sindresorhus/electron-store/blob/966a9c736318c6c51083de08e5eb5d1276e00047/index.test-d.ts#L40-L43