sindresorhus/conf

Store.set is not type checked

Trinovantes opened this issue · 1 comments

Trinovantes commented

This line makes Typescript accept any key/value for set

conf/source/index.ts

Line 197 in 06b640d

set(key: string, value: unknown): void;

I think it should be safe to remove since get does not have an equivalent overload

sindresorhus commented

I think it's used for dot-paths (like foo.bar). When TS 4.7 is out (required to move to ESM), we can update dot-prop and get type-safe dot paths, which may make it possible to remove that line.