sindresorhus/open

darwin arguments need to come before url

mshanemc opened this issue · 0 comments

use case where I found this:

open('https://google.com', { app: { name: apps['browserPrivate'] }, newInstance: true }

results in cliArguments being

--new,-a,google chrome,https://google.com, --args,--incognito

on mac, the order or arguments matters. replication

open -na "google chrome" --args --incognito https://google.com => incognito
open -na "google chrome" https://google.com --args --incognito => not incognito

I'm gonna speculate some of the other open issues may also result from the args being in the wrong order.

I made a PR. This worked for my use case/machine #332