sindresorhus/public-ip

Add more public IP checks for better resilience

silverwind opened this issue · 10 comments

Issuehunt badges

See sindresorhus/is-online#64. One or two alternative services to be checked in parallel would probably be beneficial for better resilience against outages.


IssueHunt Summary

adityapatadia adityapatadia has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

Yes, it could also check https://www.ipify.org/ through https://github.com/sindresorhus/ipify.

There's also https://checkip.amazonaws.com/

Any other good free trustable IP check APIs? Maybe from Google, Cloudflare, etc? The person taking on this issue should do some research.

@issuehunt has funded $40.00 to this issue.


ipify seems the best. I will go ahead with it. Another option I saw was https://ip.seeip.org

Amazon one is not officially documented so I think we should avoid that one.

@sindresorhus seeing this ipify module, I can't help but think it's very redundant to this module. Maybe deprecate it in favor of this module and include the ipify check here?

I am not going to use the node module. I will use GOT to get address from their API.

seeing this ipify module, I can't help but think it's very redundant to this module. Maybe deprecate it in favor of this module and include the ipify check here?

I don't see the point in deprecating it. It can be useful when you don't care about redundancy, or as an easy add when you just want the IP without having to think about how to talk to the API or what HTTP lib to use.

Opened #33

Any update on this? Is the PR going to be merged or is it blocked for some reason?

@sindresorhus has rewarded $36.00 to @adityapatadia. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00