sinnwerkstatt/runrestic

drop fastjsonschema for jsonschema

Henry78 opened this issue · 6 comments

Henry78 commented

I'm not a Python pro, but it seems to be feasible and simple to drop fastjsonschema for jsonschema to simplify packaging (jsonschema is mostly already available as dist package).

andreasnuesslein commented

hey @Henry78 ,
thank you for your comment :)

what do you mean by that? are you planning on making a .deb or .rpm? if you install runrestic with pip it will simply pull fastjsonschema anyways

Henry78 commented

I just built an AUR package (arch linux) and plan to make a .deb package too.

I know that I may install it via pip, but as a seasoned systems administrator I like everything handled by the package manger as far as possible.

EDIT: And jsonschema seems the more generic joice. So why are you using fastjsonschema for the validation?

andreasnuesslein commented

That's really nice of you :)

Well the point is: I'm not sure this project is gonna survive for that much longer. I would really really like to have this functionality directly in restic.
But realisticly, that's not gonna happen anytime soon.

If i recall correctly, one of the reasons for fastjsonschema was actually not the fastness but it had features the other didn't.
Would you happen to know if I can definitely just drop-in replace fast for regular? Then i shall gladly do so.

Henry78 commented
andreasnuesslein commented

Hey @Henry78 I switched them out; you can remove the replace_fastjsonschema_by_jsonschema.patch from your PKGBUILD

cheers

Henry78 commented

Thank you!