sismo-core/sismo-badges

Fix and create an helper to get deployments addresses

dhadrien opened this issue · 12 comments

dhadrien commented

https://github.com/sismo-core/sismo-protocol/blob/accountbound-improvements-and-airdrop-attester/tasks/deploy-tasks/full/0-deploy-core-and-hydra-s1-simple-and-accountbound.task.ts#L266

Issue with

   -> proxy: ${(await hre.deployments.all()).Front.address}
  • fix: add deployment prefix like this one:
(await hre.deployments.all())[options.deploymentNamePrefix + '_Front'].address
  • clean: create helper to be reused
Pontipilat777 commented

👍

  • 👍3
marmeladnaaV commented

I thonk you should refactor the code

Fedotff commented

👍

  • ❤️3
terrabass commented
TobianMads5 commented

👍

  • 👍2
  • 🎉2
Z1GuR commented

👍

LexLuter1 commented

👍

DikonKol77 commented

👍

RealeLR commented

Good job

VikMezz commented

Class

Z1GuR commented

cool

dafnorka commented

great