sitespeedio/compare

getting various errors when uploading 2 har files

kmaqsudi opened this issue · 11 comments

attached HAR files are from sitespeed.io waterfall tab (export HAR). uploading to compare.sitespeed.io gives error "Cannot read property ‘time’ of undefined'.

HAR-file.zip

Hi @kmaqsudi thanks for creating the issue and sharing the HARs that helps so much! I've pushed a fix. It was broken when I added the filmstrip capability but it didn't work if you didn't have any screenshots.

I've tried and it worked for me but please verify that it works for you (make sure that the page is updated).

Best
Peter

confirmed that it works when dropping HARs manually. Thanks again @soulgalore

@kmaqsudi I've the same issue when generating HARs using Firefox's devtools (on Firefox Developer Edition, so currently 78.0b4) e.g. trying to upload either file from hars.zip displays:

can't access property "indexOf", e.response.content.mimeType is undefined

This occurs whether drag-and-dropping or using the upload dialog (by clicking on the placeholder).

have not tried hars from firefox. have you tried the same using chrome?

have not tried hars from firefox. have you tried the same using chrome?

It seems to work fine (using firefox to load a chrome har). Doesn't help with FF hars though.

@xmo-odoo can you share one of the HAR files that fail and I'll fix it!

@soulgalore I put them in the original comment, though the link's probably easy to miss.

https://github.com/sitespeedio/compare/files/4750579/hars.zip

Ah sorry, let me fix this first thing tomorrow.

Ah sorry, let me fix this first thing tomorrow.

No worries, it's really not pressing.

Hi @xmo-odoo sorry it took some time. The HAR is broken (you can test it at http://www.softwareishard.com/har/viewer/). Is it from Firefox directly? If so, can you create an upstream issue at Mozilla. Also the error we got comes from PerfCascade, but I need to look into if there's a way to fix that.

Hi @xmo-odoo sorry it took some time. The HAR is broken (you can test it at http://www.softwareishard.com/har/viewer/). Is it from Firefox directly? If so, can you create an upstream issue at Mozilla.

Pretty sure it did yeah. It's FDE but it should not break anything. I'll check their bug tracker, thanks for the help (and harviewer to validate har files).

edit: yeah I just dumped a brand new har and harviewer rejects it.