sitespeedio/sitespeed.io

[Documentation] S3 Expire, incorrect description

Opened this issue · 1 comments

Feature/improvement

Hello there!
According to the documentation, to set the expiration date for S3, we should set a timestamp after how long files will be deleted, but in fact, this param Expires is about when files will be deleted.
-s3.params.Expires=31536000 to set expire to one year. it sets for AWS S3 Friday, January 1, 1971 00:00:00 GMT
image 1934

Thus, for proper expiration time, we have to do something like this:
-s3.params.Expires=$(($(date +%s) + 31536000))

Links on the documentation where mention it:
https://www.sitespeed.io/documentation/sitespeed.io/s3/#extra-configuration
https://www.sitespeed.io/documentation/sitespeed.io/configuration/

i want to work on this issue?