sjamesr/jfreesane

Some test assertions in SaneClientAuthenticationTest don't make sense

krichter722 opened this issue · 1 comments

Some test assertions in SaneClientAuthenticationTest like

@Test
public void testSaneClientAuthenticationWithMissingFileDoesNotFail() {
    String filepath = "NON_EXISTENT_PATH_" + UUID.randomUUID().toString();
    SaneClientAuthentication sca = new SaneClientAuthentication(filepath);
    Assert.assertNotNull(sca);
}

don't make sense because either the constructor throws an exception, then the assertion is never reached or it is guarantee to be not null.

experienced with jfreesane-0.97-9-ga38a0fd

Those assertions were in SaneClientAuthenticationTest only, I checked the other tests.