Note about processing `ack` event
vogdb opened this issue · 5 comments
Currently we don't complete transaction on ack https://github.com/cargomedia/janus-gateway-js/blob/f4ede2645f4a8c961cfd84f1d31564d456f45ba3/src/transactions.js#L52
Also ack events that are coming in response to plugin messages do not reach plugin level processing because they don't contain handle_id or sender fields. So, if you create a request from plugin and expect an ack response, you should expect it on plugin's session.
What shall we do with it? I don't know >_<
yes, he definitely knows!
"async" request are always resolved by an event (with the transaction key from the request), as explained in the janus documentation:
The watch , start , pause , switch and stop requests instead are all asynchronous, which means you'll get a notification about their success or failure in an event.
see https://janus.conf.meetecho.com/docs/janus__streaming_8c.html#streamapi
So skipping ack for async request is correct, I don't see anything to change here... let's keep the code as it is!
hum, there's maybe only the keepalive... but i think we don't care about the response in this case...
Closing for now