Add more lint reviews

Question

Add more lint reviews

sjparkinson opened this issue 10 years ago · 9 comments

sjparkinson commented 10 years ago

.less with twitter/recess
.php with fabpot/PHP-CS-Fixer
.php with sebastianbergmann/phpcpd
.php with sebastianbergmann/phpdcd
.json with seld/jsonlint
* trailing whitespace

Done

.php with squizlabs/PHP_CodeSniffer
composer.lock with sensiolabs/security-checker

Answer 1 · 2014-08-21T10:19:22.000Z

@sjparkinson
Maybe worth to add .php with https://github.com/fabpot/PHP-CS-Fixer ?

Answer 2 · 2014-08-21T10:31:54.000Z

Ah interesting, thanks for the link. I'll have a look at adding it using the dry-run argument.

Answer 3 · 2014-08-21T10:33:55.000Z

@sjparkinson you may be intrested with --diff option as well

Answer 4 · 2014-08-21T10:42:11.000Z

@sjparkinson I see you add some more tools, so maybe add them too:
sebastian/phpcpd
sebastian/phpdcd
?

Answer 5 · 2014-08-21T10:44:56.000Z

👍 they look very useful to me

Answer 6 · 2014-08-21T11:14:44.000Z

Here is my complete composer.json for static analysis:

{
    "require": {
        "fabpot/php-cs-fixer": "@stable",
        "pdepend/pdepend": "@stable",
        "phploc/phploc": "@stable",
        "phpmd/phpmd": "@stable",
        "phpunit/phpunit": "@stable",
        "sebastian/phpcpd": "@stable",
        "sebastian/phpdcd": "@stable",
        "sensiolabs/security-checker": "@stable",
        "squizlabs/php_codesniffer": "@stable",
        "wimg/php-compatibility": "@stable"
    }
}

Maybe you will want to add sth more, like security-checker (client of free webservice only!) or php-compatibility (which is very usefull during changing php version or developing for version not used to)

Answer 7 · 2014-09-05T11:50:01.000Z

maybe add https://github.com/Seldaek/jsonlint as well ?

Answer 8 · 2015-09-21T21:44:36.000Z

any news on that?

Answer 9 · 2015-09-21T22:35:15.000Z

any news on that?

Nope, I haven't been able to dedicate much time to projects lately. I'm more than happy to accept PR's for any of these!