skalenetwork/skale-manager

Fix call that determines if rotation is in progress

sync-by-unito opened this issue · 3 comments

sync-by-unito commented

In the previous versions of SM, we’ve separated {{initExt}} and {{exit}} transactions, which causes errors in skale-admin. We’re relaying on {{isRotationInProgress}} call to start rotation activities and now this call returns {{True}} right after {{initExit}} transaction.

We need a call that will return {{True}} ONLY after main exit transaction for the chain (when the new group is generated).

┆Issue is synchronized with this Jira Bug
┆Attachments: Screenshot from 2022-02-16 13-42-45.png

sync-by-unito commented

➤ Automation for Jira commented:

Corresponding Pull Request #775

sync-by-unito commented

➤ Automation for Jira commented:

Corresponding Pull Request skalenetwork/skale-manager-interfaces#15

sync-by-unito commented

➤ Oleksandr Sydorenko commented:

Verified on Regression network
skale-manager 1.9.1-develop.7
Steps to reproduce:
call init exit
check node rotation contracts

Transaction initExit
https://rinkeby.etherscan.io/tx/0xd7dc61534d5acef58dd684b0f2a5a1874cde87390ab217d8736ff36d20ff7580 ( https://rinkeby.etherscan.io/tx/0xd7dc61534d5acef58dd684b0f2a5a1874cde87390ab217d8736ff36d20ff7580 )
nodeRotation contract:
https://rinkeby.etherscan.io/address/0xd5f24B17E80D47AD2263f08675442C277a533212#readProxyContract ( https://rinkeby.etherscan.io/address/0xd5f24B17E80D47AD2263f08675442C277a533212#readProxyContract )

Node rotation in progress, but new Node is not found - new Group is not formed (will be formed after node Exit)

!Screenshot from 2022-02-16 13-42-45.png|width=591,height=612!