skariel/webalchemy

UUID as session id

johngoodleaf opened this issue · 1 comments

I notice we're using a random int here https://github.com/skariel/webalchemy/blob/master/webalchemy/server.py#L46-50

Would the uuid module be a better choice? (I haven't benchmarked to see how it performs relative to a straight random integer.) Even a random uuid, if not guaranteed unique, is practically unique.

done. as of 8e17fdd webalchemy uses a version 1 uuid as specified by RFC4122, see here: http://tools.ietf.org/html/rfc4122.html (this is just uuid1 from Pythons uuid package)