skarupke/ska_sort

Warnings In code

Opened this issue · 1 comments

TrianglesPCT commented

VS2015 reports 3 warnings

They are listed here:

Warning C4127 conditional expression is constant ska_sort.hpp 1119
Warning C4457 declaration of 'end' hides function parameter ska_sort.hpp 1123
Warning C4127 conditional expression is constant ska_sort.hpp 1179

eloj commented

#7 Likely fixes the middle one, though it's possible that there are several different shadows and I just haven't had an instansiation that surfaces them all (doesn't help that the test file doesn't build out of the box).