Implement groups-no-empty rule
Closed this issue · 6 comments
Not clear how this differs meaningfully from groups-no-redundant, so putting on hold. Can revisit or close after some more thought.
@christianklotz I went to implement this, but looks like it's very difficult to actually create an empty group in Sketch. Sketch seems to automatically delete empty groups itself, e.g. when you remove the final layer in a group, the group disappears too.
It does do that but you can still drag a single item out of its group and the group won’t be deleted 😅
On that basis should we press ahead with this rule? Seems kinda niche ... ?
It does cover the "unintended garbage in the document" category for sure but that's more in favour of keeping it. I'd probably use this one as part of my defaults but that's also because I do actually end up with empty groups fairly often.
Okey let's add it. If you end up with empty groups then that's good enough for me at this stage, I just wasn't sure if it happened in the wild with Sketch's apparent auto-clean up.