[Bug] azure-configuration branch is missing
alextitov1 opened this issue · 10 comments
Describe the bug
Workflow "Check step 2, Set up the Azure environment" fails at the job. Create azure-configuration pull request with a error:
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, No commits between main and azure-configuration, Head ref must be a branch (createPullRequest)
Error: Process completed with exit code 1.
To Reproduce
Steps to reproduce the behavior:
Follow Readme.md guide at the step 2.16 commit checks will fail and you will not be able to proceed the course.
Additional context
at this step workflow should create a PR from azure-configuration branch which is currently missing in the this template
See the discussion board for more on this: https://github.com/orgs/skills/discussions/14
It's not that the branch is missing. There is a missing yaml file (spinup-destroy.yml) and a missing commit of that file to the azure-configuration branch. This means that the head and base refs point to the same commit when trying to create the PR. That will throw the error you got because you can't create a PR with no commits in it. There must be a difference in history between HEAD and base refs.
I think everyone is waiting for the Skills team to take another look at this lab, because there are a number of issues with it that need to be fixed (See dicussion thread about it.)
Thanks for the information, is there any timeline for the bug fix? Thanks！
@heiskr / @emilyistoofunky any thoughts about this ?
We're open to pull requests. I believe a contractor ported this course from a previous Learning Lab version:
I've opened a PR for this. It's still WIP and I'd appreciate some input from the Skills team. Step 2 requires a spinup-destroy.yml workflow to be added. Originally, this was added via a step and bash script in the .github/workflows/2-setup-azure-environment.yml workflow. To automate the adding of the spinup-destroy.yml workflow file, a PAT with workflow scope will need to be used.
Would it be better to get the learner to create the scoped PAT and add it to their course repo, or would it be better to get the learner to add the spinup-destroy.yml workflow themselves (along with branch and PR)? (Or option 3 which I haven't thought of?)
I'll need to defer to @skills/skills-content-reviewers for questions on course content.
We're now in December. Any chance this lab will be corrected anytime soon?
Any updates?
This exercise should be removed from the learning path at https://learn.microsoft.com/en-us/training/modules/github-actions-cd/3-create-workflow-deploy-azure
until it is fixed.
Thank you for opening this issue. I'm closing this issue out per #20 (comment)
The GitHub Skills folks don't control or influence the content on Microsoft Learn, just fyi.