skinofthesoul/grav-plugin-automagic-images

--> Being added after divs that contain an html comment <!-- -->

Opened this issue · 0 comments

Similar issue as to what was reported by #6 but I'll go into more detail into what I'm seeing since it's actually breaking my website.

On any page if there is a commented out section using an extra and --> will be added after the originally commented out . This breaks layouts as the cascade very quickly. I did some testing with commented out divs with or without twig content and the issue persists as long as there is any html element that uses < element > (spans, sections, paragraphs).
If I keep the comments but put a   inside the breaking stops. Must be a problem with how the plugin handles comments or divs. Issue persists on pages with or without classes specified in the plugin configuration.

On closer inspection I'm seeing it add a single "-->" after the first open

tag inside of the comment. This closes the comment escaping all the originally commented out code.

Also, the plugin doesn't seem to generate the srcset for an image even though it generates the sizes in the img tag. Couldn't get the plugin to work because of this. Images get generated but only the smallest size is available for use by the browser. Docs suggest that srcset is generated by Grav but I haven't been able to see any changes even though the files exists in the page. Might be an issue with Grav itself.

Some images for reference: https://imgur.com/a/vBeGn4h