skip2/go-qrcode

incorrect range of timing patterns

ksrnnb opened this issue · 0 comments

Last iteration m.size-finderPatternSize-1 for adding timing pattern is on separator pattern.
It happens to be false, but it seems to be a misunderstanding.

I think it should be for i := finderPatternSize + 1; i < m.size-finderPatternSize-1; i++ {.

go-qrcode/regular_symbol.go

Lines 172 to 181 in da1b656

func (m *regularSymbol) addTimingPatterns() {
value := true
for i := finderPatternSize + 1; i < m.size-finderPatternSize; i++ {
m.symbol.set(i, finderPatternSize-1, value)
m.symbol.set(finderPatternSize-1, i, value)
value = !value
}
}