skoerfgen/ACMECert

PHP 8.1 support

dqos opened this issue · 2 comments

dqos commented

There are some issues with PHP 8.1, I will try to do PR with a fix later this week once I have time.

Deprecated: Optional parameter $termsOfServiceAgreed declared before required parameter $eab_hmac is implicitly treated as a required parameter in ACMECert.php on line 43

Fatal error: Uncaught Exception: Could not load Private Key or CSR (Optional parameter $termsOfServiceAgreed declared before required parameter $eab_hmac is implicitly treated as a required parameter | error:02001002:system library:fopen:No such file or directory): file://cert_private_key.pem in ACMECert.php:294

I think moving the option param $termsOfServiceAgreed to the end would fix it.

skoerfgen commented

Thank you for reporting this issue!

Instead of moving the parameter, just removing the default value for $termsOfServiceAgreed should fix it.

You can find the new code in the php8 branch.

Diff

dqos commented

Thanks, this works fine!

  • 👍1