Lookup Table for Player names
Opened this issue · 2 comments
Thanks for creating package and keeping scores up to date
In the atp_players and wta_players datasets you have a unique player_id to link to other datasets
However, it is not used in, say, the _elo files (although player name, if unique, can be substituted)
or the -_odds which is even more problematic
Any chance of creating a lookup table to cover this, please
Just added a lookup table to match matchid/player_id between the odds and atp_matches (see atp_odds_match_lookup, wta_odds_match_lookup). (Also updated betting data at the same time)
For the elo tables, the player name should be the same as "name" in atp_players/wta_players
Thanks very much. Have not looked at the look up tables in detail yet, but unless I'm missing something there are lots of duplicated names in the atp_players file
atp_players %>%
count(name, sort = TRUE) %>%
filter(n>1) %>%
tally()
Gives a total of 848. From a cursory examination, most of these look same person repeated more than once - sometimes with more info in. Though, of course, there could be different people with the same name, potentially
Anyways, do not go to too much trouble on my behalf. I'll probably just write a one-off blog post on the package, excluding tables with possible issues