skrapeit/skrape.it

[BUG] Android Sample does not run. Github html updated to remove class.

mufasa08 opened this issue · 1 comments

Describe the bug
Changes to github html uses in sample android application breaks current sample.

Classes have been changed.

Code Sample

                        withClass = "follow-list"
                        li {
                            findAll {
                                map {
                                    User(
                                        name = it.h3 {
                                            withClass = "follow-list-name"
                                            findFirst { text }
                                        },
                                        imageUrl = it.img {
                                            withClass = "avatar-user"
                                            findFirst { attribute("src") }
                                        }
                                    )
                                }
                            }
                        }
                    } 

The above code no longer works.

Expected behavior
Proper parsing of github page

Additional context
I've created a branch and updated and would like permission to open a pull request to fix this issue.
Alternatively the solution I propose is as follows.

                htmlDocument {
                    div {
                        withId = "repos"
                    ol {
                        li {
                            findAll {
                                map {
                                    User(
                                        name = it.h3 {
                                            findFirst { text }
                                        },
                                        imageUrl = it.img {
                                            withClass = "avatar-user"
                                            findFirst { attribute("src") }
                                        }
                                    )
                                }
                            }
                        }
                    }
                }
                }
            }```

Cool thx a lot :) just open a PR, you are welcome :)