packaging>=23.1 - can it move to dev instead of install_required ?
Opened this issue · 2 comments
Problem Description
If the following can move from install_required to dev or so, I would be happy:
packaging>=23.1
Tried to use skrub on Kaggle, no Internet. brought into the environment the 0.1.0 wheel. Yet above causes issues.
Feature Description
If the following can move from install_required to dev or so, I would be happy:
packaging>=23.1
Tried to use skrub on Kaggle, no Internet. brought into the environment the 0.1.0 wheel. Yet above causes issues.
Alternative Solutions
Move it to dev?
Additional Context
No response
thanks for reporting.
dependencies are checked when importing the package (not just when installing it), and the machinery that does that uses packaging
. This was added in #365
maybe @GaelVaroquaux or @Vincent-Maladiere have more insights on the pros and cons of having this check?
in any case I'm not sure why packaging
would be more problematic than the other dependencies; could you provide a description of your environment (eg conda list
) and the exact error message? thanks!
Without internet, the Kaggle environment could not find 'packaging>=23.1', probably it has something earlier. I removed that dependency (commented out 'packaging>=23.1') in my cloned copy of 'skrub' on my laptop, rebuilt the 'skrub' package, and used that wheel (uploaded it to Kaggle to where it can access it also when no Internet). It worked for me on the same Kaggle environment from above (also when no Internet connection).
What if this or another dependency/package are really needed? I should bring their wheel also. But anything that is not a must would be better used only when needed. I assume 'packaging' is more related to build/dev time.