sky-music/sky-python-music-sheet-maker

Move constants to class attributes

Closed this issue · 1 comments

Relocate constants from instance attributes inside the init function to class attributes

Beware doing that because list comprehension cannot access the class scope, and also class attributes can be overridden if the attribute is set in the parent class, called with super().init()
Basically setting a variable to None in the init is not a good idea