Support multiple Input topic
zdenotubel opened this issue · 10 comments
Hello,
Alto team is using this component for "Event Triggered Action" project, where the requirement is to delay action for configurable time.
KMS is working great, but we have got requirement to create multiple input topics for KMS based on territory and I would like to ask for your thoughts about this.
I have done the change and I will try to push it to multpile-schedule-topics branch. The main change is done in kms object and everything else is fall out from there.
Thanks,
Zdenek Tubel
hello @zdenotubel, we dealt with this in our apps by adding the territory to the key of the schedule producer record when writing the schedule to Kafka.
Would this not satisfy your requirement?
I'm not against the proposal, it makes a lot of sense. I'm just thinking it might be easier for you to just add the territory to the key.
Hello @lacarvalho91,
Requirement is to have both input and output topic specific to territory, but later also for different clients.
My understanding of this requirement is that in case ETA will be used by multiple clients/territory, they will want to have option to further alter KMS to support different priority for different input topics so that less important messages are not blocking those more important.
@zdenotubel OK - will your schedule input topics have consumers other than the KMS then?
As of now it should be just KMS.
Fair enough. From what you have said, and since KMS is going to be the only consumer of the topics, it does sound like you could just have one topic for now with the territory appended to the schedule key when writing to the input topic. You can still have as many output topics as you like, since the output topic is contained within the Schedule topic.
What you mentioned about priority is obviously very different though, I have no idea how that would work if I'm honest but we can cross that bridge later it sounds like!
Feel free to raise a PR anyway and I'll take a look.
Can you please add me to a group with write permissions so I can push my branch?
@zdenotubel I have given write access to alto
PR created
Thank you
@zdenotubel KMS version 0.14.0 released which includes your changes as well as akka-kafka version update by @charlie-mcneill.
Are you happy for me to close this issue?
Yes, thank you.