diff() and Unicode surrogate pairs

Question

diff() and Unicode surrogate pairs

Closed this issue 6 years ago · 3 comments

Since quill-delta has moved to fast-diff@1.2.0, who now is unicode-safe (jhchen/fast-diff#4), using .diff() on document that has a retain leading to a unicode surrogate pair being broke, there is a Maximum call stack size exceeded error.

Here is in 4.0.1 without error: https://repl.it/repls/PungentColorfulScandisk
And in 4.1.0 with the error: https://repl.it/repls/FrailLimitedCoolingfan

My guess is that as quill-delta is not unicode-safe, any used dependency shouldn't be neither

Answer 1 · 2019-02-11T08:34:36.000Z

This seems to be a bug with fast-diff. Can you post an issue there?

Answer 2 · 2019-02-11T10:32:15.000Z

Will do, but that would still be an issue to have a unicode aware dependency and not quill-delta no?

Answer 3 · 2019-02-13T17:38:33.000Z

quill-delta's unicode awareness comes from fast-diff