slackhq/circuit

Consider making NavEvent.screen public

milis92 opened this issue · 3 comments

milis92 commented

Currently, the NavEvent.GoTo and NavEvent.ResetRoot screen parameter is marked as internal. Consider making it public so we can check and override the navigation destination based on the requested target.

stagg commented

I'd be cool with this, has utility when used with nested presenters as well.

  • 👍1
ZacSweers commented

Wanna send a PR?

milis92 commented

Sure, il do it later today.