slackhq/compose-lints

Improve mutable parameters message

ZacSweers opened this issue · 3 comments

ZacSweers commented

Feels like we could improve this a few ways

  • Specify which parameter is mutable
  • Should stable parameters be legal? i.e. like the SnapshotStateList here
  • Is the linked rule correct?

image

ZacSweers commented

Actually I see SnapshotStateList is explicitly targeted. @chrisbanes @mrmans0n curious for more details!

chrisbanes commented

Hmm, I don't remember tbh. SnapshotStateList shouldn't be targeted as it's stable

ZacSweers commented

I'll remove those for now then 👍