Feature Request: Game framerate adjustment
Avasam opened this issue · 4 comments
Just discovered this tool, thanks!
Not sure what's the point of "framerate" (doesn't seem to affect the result), however, I would like to see a "game's framerate". It could be useful to adjust the milliseconds to a frametime that's possible.
For example, if the game ran on PAL (50hz), but the video is at 60FPS, a time of 0s 767ms is impossible (despite the video having such a timestamp), and could be nudged to the appropriate ms step (0s 760ms or 0s 780ms @ 50hz, I can't remember how rounding goes for those situations).
The same could be done for 25 and 30FPS games.
Oh I just realized, the framerate is used when when parsing the starting frame and ending frame.
Maybe it shouldn't, and instead be used when computing time.
This would also leave the starting and ending frames accurate to what they were taken from the video.
I can open a PR to make that change if you'd like. Sounds like a pretty simple one.
I am very sure this repo is abandoned. But i am curious how does using the frame while computing the time different than applying it to the start and end frame.
I think it would make more sense to have the start and end with the framerate applied so the time in the mod message would be exactly the difference between the start and the end
i am curious how does using the frame while computing the time different than applying it to the start and end frame.
The resulting time should be the same. The difference would be usability/UX. Allows you to set the framerate afterwards if you forgot or didn't notice.
I am very sure this repo is abandoned.
eh, if it is and I get no answer I can always just fork it.
Actually you've got a point