[fix] description of make in CONTRIBUTING.md
Closed this issue · 6 comments
🐛 🐛 🐛
Chapter name
Please also flag with corresponding label
No chapter, https://github.com/slds-lmu/lecture_i2ml/blob/master/CONTRIBUTING.md
Location
Please provide as much context as possible, slide numbers change easily
https://github.com/slds-lmu/lecture_i2ml/blob/master/CONTRIBUTING.md#slides
Description & proposed fix
The guide says to use make clean for deleting PDF files, but this does not work anymore, apparently this was changed to make rmpdf? If yes, please update the contributing.md, thanks @lisa-wm !
I'm not quite sure tbh, for me this still works, and the clean target also still exists in the Makefile. Could you please elaborate @ludwigbothmann?
On another note, I updated the guidelines regarding compilation (new margin handling) - sorry for the delay :) #1169
now I see it as well, it is even more confusing :) in exercises it is make rmpdf in slides it is (as it was always) make clean => any idea why?
Yeah that doesn't make sense, idk why exactly :) I'll change the exercise makefile ➡️ #1170
can we close this one, then @ludwigbothmann?
Yes, thx 🙏
