slei109/PATNet

Code and paper seem inconsistent

Lzuze opened this issue · 1 comments

Lzuze commented

Thanks for releasing the code!
But I found that the implementation of the transformation matrix and the paper description seem to be inconsistent.
In your code, the matrix was implemented as:
P = torch.matmul(torch.pinverse(C), R)
but in your paper, the matrix were calculated as
image

Accordingly, the matrix should be implemented as:
P = torch.matmul(R, torch.pinverse(C)).
It really confused me. Looking forward to your reply!

They are two different way to implement the same thing. It depends on the dimension of your W, P and A. Here, WP=A, the dimension of W is CxC, P is CxN and A is CxN. But in the implementation, for the convenience, the shape of R is NxC, thus P=torch.matmul(torch.pinverse(C), R). If you define the shape of R as CxN in your code, then you can implement P=torch.matmul(R,torch.pinverse(C)).