Python 3 support?
Closed this issue · 4 comments
It looks like its just python2 compatible, if you're interested in making this python3 compatible (and it turns out to be as straightforward as it looks at first glance with only needing to tweak print statements), I'm happy to submit a PR.
You're right, I haven't maintained Python3 standards. If you don't mind submitting a PR, that would be much appreciated! Otherwise I will get to it eventually.
So if you look at the https://github.com/michaelpacer/pyhawkes/tree/futurizing branch you'll see that I've begun to do this (first with the futurize script), but then ran into some other problems with the way that different packages/submodules/modules are imported in gslrandom(slinderman/gslrandom#4) and pybasicbayes(mattjj/pybasicbayes#22). I see that these other packages need to be brought up to python3 compatibility, but I fear that I am in over my head at pushing all of these dependencies up to compatibility at the same time especially since there seem to be major infrastructural changes that are happening for most of these projects currently (e.g., the nonexistant internals module that was attempted to be imported by the setup.py in pybasicbayes).
I'm going to have to step away from this for a little while, since being able to move forward effectively requires having a working model of all the intricacies of these different parts playing together…including knowing which version of the structure can be expected from pybasicbayes…
I don't know when I'll be able to start looking at incorporating some of this into cbnx, since its primarily built on python3 (I don't think I wrote it to be python2 compatible…but I could try pasteurizing it…but I don't want to be developing it in python2 and cbnx is still badly in need of further development).
The fact that you've managed to build something on top of the complexity of all this stuff is really impressive — it just means that I have a bit of difficulty keeping up :/, but I'm doing my best!
As you correctly assessed, many of the problems you're having stem from the fact that I reorganized pybasicbayes recently without really taking the time to make it backwards-compatible or warn anybody (or make sure the install still worked).
That said, I have some time to fix my mistakes now, so if you open issues (here or in pybasicbayes) for the problems you run into (e.g. pastes of import errors) I can probably clean things up pretty efficiently.