Custom Button doesn't open expected URL
DannyyyOnGit opened this issue · 6 comments
Describe the bug
After setting up a custom button and it appearing on Discord Presence. It doesn't seem to work as expected.
To Reproduce
Steps to reproduce the behavior:
- Set up custom button label and url (see screenshot)
- Notice button appearing as expected
- Click button to open url
- Button doesn't open external browser window
Expected behavior
Clicking the button should open your default browser with the expected url.
Screenshots
Environment:
- MusicBee Version: 3.4.7805 P
- Plugin Version: v2.2.0
Additional context
I'm using discord for desktop and not the browser version. The browser console in Discord Canary (Ctrl+Shift+I) doesn't give any info about this either.
I'll be checking this more further tonight.
I'll be checking this more further tonight.
Not sure if this is caused by your code though, could be Discord.
Is there any way I could provide you logs or something useful?
I'll be checking this more further tonight.
Not sure if this is caused by your code though, could be Discord. Is there any way I could provide you logs or something useful?
I just confirmed the issue just now. This happens because the other parts of URL like ?= get URLEncoded. Thus ended up like this.
I'll be making a PR fixing this issue.
@aikoofujimotoo @sll552 We might have to re-open this.
It still doesn't work for me on desktop and mobile. This is my config:
Hmm. I can't reproduce it on my end. If you are trying to open the URL with the same discord instance/account, it will not open as per limitation stated here: Lachee/discord-rpc-csharp#184
Also if you have very long URL, for some reason it will not update/show up the rich presence at all.
Hmm. I can't reproduce it on my end. If you are trying to open the URL with the same discord instance/account, it will not open as per limitation stated here: Lachee/discord-rpc-csharp#184
Alright the instance makes sense. I was only testing using my own account.