slurdge/goeland

Some relative links don't get rewritten

Cyberbeni opened this issue · 8 comments

Cyberbeni commented

Describe the bug
Relative links in certain RSS feeds don't get rewritten

To Reproduce

  1. Generate email from the following feeds:
  1. Click on links in emails

Expected behavior
Relative links in the linked rss feed get rewritten

Cyberbeni commented

I found out that you can specify the base url for relative links, which should be more robust than trying to regex all the possible ways to write relative links:

<base href="https://developer.apple.com" />
slurdge commented

I'll look into it. You suggest that goeland manually put the base into the email right ?

Cyberbeni commented

I currently use different templates for this. Using base doesn't work if multiple feeds are merged and would need different base urls, so I don't know what would be the best solution.

slurdge commented

You are right, and even Gmail&Hotmail would filter out the base. I've added an additional rule into the "links" filter, that rewrite src&href with the correct base URL. It works in your two examples, so let's cross fingers some strange feeds won't pop out.

slurdge commented

Please try 0.16.0 and tell me if the situation is better :)

Cyberbeni commented

The newest ghcr.io docker image is still 0.15.0

edit: the build is still in progress: https://github.com/slurdge/goeland/actions/runs/6668620883/job/18124562936

slurdge commented

My bad, action is still running :)

Cyberbeni commented

It seems to be working correctly