smarco/WFA2-lib

WFA2-lib commons.h bleeds C macros

pjotrp opened this issue · 5 comments

By including wfa2-lib headers into vcflib (for the great vcfwave tool) we bleed in a set of macros that are defined, such as FORMAT, EOL and TAB. A library should not export these by default! See

See vcflib/vcflib#359

Downstream I have the option of not including wfa2-lib in the vcflib headers, or explicitly undefining macros. Both not what we want. Can you create a version that does not bleed macros? I prefer an upstream solution :). And thanks again for a great library!

Sure, Pjotr. At once.

@smarco I can do a PR if you want.

If it is urgent, go for the PR. No problem.

OK, you can assign me. I have the test setup in vcflib ;)

Closed with #38