smarkets/marge-bot

Make marge-bot fit for kernel development

karolherbst opened this issue · 2 comments

Hi everybody,

I am looking into using marge-bot for Linux kernel development. One missing feature is that every patch handled by a subsystem maintainer, needs to have a Signed-off-by tag. Same goes for merge commits.

So my idea was that once a Merge Request is assigned to marge (and restrict this to maintainers) that marge-bot adds Signed-off-by tags with the name and email of the user assigning the Merge Request to marge-bot.

I didn't check if the gitlab API allows to query this information though and I didn't really looked into marge-bots source code yet, but maybe anybody of you have some ideas what can be done here.

Another thing is, that we don't use Part-of but Link to point towards the place where the discussion of a patch happened. Although those are slightly different in the meaning, Link points e.g. to a patchwork URL of the specific patch and Part-of points towards the whole thing, I think being able to add a custom tag name instead of Part-of is still good enough.

Thanks

Another thing which could be problematic, that we need to use specific email addresses for users, not their "main" email or whatever.

I also even saw that the bot needs to be admin in order to even fetch those. Maybe it would make sense to add a mapping file to map from accounts to emails?

Another thing: we can't have the bot to be the committer of the commits :/