smartdevicelink/sdl_javascript_suite

JS Docs for VoiceCommandManager setVoiceCommands say that the method resolves later than it actually does

renonick87 opened this issue · 0 comments

Bug Report

The JS docs for the setVoiceCommands say that the method returns a Promise that resolves when the old commands are deleted and the new ones are added. However in actuality, the method resolves after the task to update the commands is added to the task queue since there is no await to postpone the resolution of the Promise. The current functionality matches the functionality of Java and iOS, so no code changes are required but the docs will need to be updated to match.

Expected Behavior

The docs should say that the method resolves when the update task has been added to the manager's task queue.

Observed Behavior

The docs say that the method resolves after the old commands are deleted and the new ones are added.